Upgrade PyXForm dependency to v1.1.0 #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
pyxform-1.-upgrade
branch
from
3349907
to
ac9db62
Compare
DavisRayM
changed the title
DavisRayM
force-pushed
the
pyxform-1.-upgrade
branch
from
a37d1eb
to
f21bbe3
Compare
DavisRayM
force-pushed
the
pyxform-1.-upgrade
branch
2 times, most recently
from
e0be485
to
f45ab96
Compare
Add MULTI_SELECT_TYPE and SELECT_BIND_TYPE tags removing the previously used SELECT_ONE and SELECT_MULTIPLE variables. More info: XLSForm/pyxform#410
Modify Export Builder tests passing in the new 'default_name' arguement to PyXForms 'create_survey_from_xls' function and use SELECT_BIND_TYPE and MULTIPLE_SELECT_TYPE common tags instead of static values. More info: XLSForm/pyxform#375
Modify _get_sav_options function to work with the new string binding for select one elements
Update the error raised when an id_string is invalid. PyXForm now utilizes the filename as the form_id if it's not explicitly set in the settings sheet. More Info: XLSForm/pyxform#389
As of PyXForm v1.0.0 the name of the file is no longer used as the root node. More Info: XLSForm/pyxform#375
As of PyXForm v1.0.0 the 'list_name' field has been added to a forms generated JSON. More Info: XLSForm/pyxform#357
Update the 'test_choice_duplicate_error' test to expect the correct error message raised by PyXForm.
Update the test and add a docstring explaining when the error occurs
DavisRayM
force-pushed
the
pyxform-1.-upgrade
branch
from
f45ab96
to
aae3141
Compare
ukanga
approved these changes
Mar 27, 2020
|
@DavisRayM I have tested the following scenarios and they have passed QA.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
pyxformtov1.1.0Steps taken to verify this change does what is intended
Pending:
Side effects of implementing this change
Still researching, impacts of this change
Closes #1787